feat(mcp): add list_plugins and get_node_definition tools#381
Merged
streamer45 merged 2 commits intoApr 25, 2026
Conversation
Add two new MCP tools: - list_plugins: Lists installed plugins filtered by caller permissions, delegating to plugin_manager.list_plugins() with is_plugin_allowed filtering. - get_node_definition: Looks up a single node definition by kind, with is_node_allowed permission check and filtered_node_definitions() reuse. Update server instructions to mention the new tools. Add three integration tests: - mcp_list_plugins_returns_results - mcp_get_node_definition_found - mcp_get_node_definition_not_found Signed-off-by: StreamKit Devin <devin@streamkit.dev> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
Contributor
Author
|
✅ Reviewed on |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Add missing is_plugin_allowed check for plugin:: prefixed kinds in get_node_definition, matching the two-level permission pattern used in filtered_node_definitions and websocket_handlers. Without this, a denied plugin kind would produce a misleading 'not found' error instead of 'permission denied'. Signed-off-by: StreamKit Devin <devin@streamkit.dev> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
streamer45
deleted the
devin/1777138115-mcp-list-plugins-get-node-definition
branch
Contributor
Author
MCP Comprehensive Test ReportDate: 2026-04-25 | Branch: Summary
Overall: ALL 89 TESTS PASS PR #381 Specific Results (list_plugins, get_node_definition)
No regressions in existing tests. Full report: https://staging.itsdev.in/sessions/c0e3bffbfefe401daa6aeeb33d9c2e89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two new MCP tools to the
StreamKitMcpservice for plugin discovery and targeted node lookup:list_plugins— Lists installed plugins filtered by caller permissions, delegating toplugin_manager.list_plugins()withis_plugin_allowed()filtering. Takes no arguments beyond auth context.get_node_definition— Looks up a single node definition by kind. Checks bothis_node_allowed()andis_plugin_allowed()(forplugin::prefixed kinds) before using the existingfiltered_node_definitions()helper to find the matching definition. Returns anot founderror for unknown kinds andpermission deniedfor disallowed kinds/plugins.Also updates the
with_instructions()string inget_info()to mention both new tools.Integration tests added (
apps/skit/tests/mcp_integration_test.rs):mcp_list_plugins_returns_results— callslist_plugins, verifies it returns a JSON array (empty in test server since no plugins are loaded)mcp_get_node_definition_found— callsget_node_definitionwithkind: "core::passthrough", verifies the definition hasinputsandoutputsarraysmcp_get_node_definition_not_found— calls with a nonexistent kind, verifies error responseReview & Testing Checklist for Human
list_pluginsreturns correct results when plugins are actually loaded (test server has none)get_node_definitionreturns complete schema/pin data for a known node kindNotes
list_nodesandlist_plugins_handleris_plugin_allowedguard per Devin Review feedback to match two-level permission patternLink to Devin session: https://staging.itsdev.in/sessions/7e9338fcc6804028ac81568bcd65b7b1
Requested by: @streamer45